I want to delete this branch but I don't want the code to go away forever 😛

e.g. even if I close this PR, I can use the PR to restore the branch! 😄

This would be great to get a release of!

@ljharb Can you let me know if this code actually works though? I have no way of checking.

I can only confirm it works secondhand atm, but by tomorrow I'll have first-hand confirmation :-)

Let me know. We said in #3281 that we were willing to release this, so might as well resolve this. (I really don't like having stale branches sitting around).

@timdorr You okay with making this change?

@ljharb ping

@taion sorry; i've been traveling. I believe @goatslacker has verified that this works beautifully, but hopefully he can chime in :-)

@taion been traveling as well, yeah the change works well.

Any objections to releasing this?

No, go for it.

That was meant for @timdorr 😄

Sorry, having to swap out some production systems on the fly at work, so I've been running around like a chicken with my head cut off all day. Haven't even eaten lunch :(

LGTM. Worst case you can yank the version if it's bad.

Sorry! Just wanted to make sure your "but why?" was addressed. (:

It was more of a joking "why reach into the past" kind of thing. No worries :)

Thanks for your work on this!

I can confirm that 13.4 worked without these changes on 15.4. This seems to be mostly fixes to the unit tests. There is one fix that needs to be addressed in the Link component that wasn't addressed, that is a warning for applying additional props onto the a tag in the render func.

Ugh okay this is released as v0.13.6. I vote that we should just delete the 0.13.x and say it's officially dead going forward, explicitly with no PRs or further releases.

Agreed. I'll go nuke it into oblivion now.

Deleting published code is not so good :-( please don't do that, even if there won't be further releases.

Well, the former tip of the 0.13.x branch and the v0.13.6 tag are the same. I don't think we should delete the tag. No code is gone.

It's not deleted. Only the branch is gone. The tag remains: https://github.com/reactjs/react-router/tree/v0.13.6

I believe they are talking about just deleting the branch not the tag.
Deleting the branch should be fine. A warning should be placed in the
Readme that 0.13 is not supported anymore and if someone wishes to support
the release they can branch from the tag.

Drew Foehn
[email protected]
+1 (347) 443 4031

Just making sure, thanks :-)